Merge branch 'master' into tf/refactor-euclidean-division

noir-lang · Feb 2, 2024 · 8b49190 · 8b49190
2 parents 14fb79b + b3ddf10
commit 8b49190
Show file tree

Hide file tree

Showing 421 changed files with 13,641 additions and 2,606 deletions.
diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml
diff --git a/.github/ISSUE_TEMPLATE/idea_action_plan.yml → .github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/idea_action_plan.yml → .github/ISSUE_TEMPLATE/feature_request.yml
@@ -1,5 +1,5 @@
-name: Idea Action Plan
-description: Outline the scope and steps for implementing an enhancement. Start with "Ideas" instead to request and discuss new features.
+name: Feature Request
+description: Suggest an idea for this project.
 labels: ["enhancement"]
 body:
   - type: markdown

diff --git a/.github/scripts/noir-js-test.sh b/.github/scripts/noir-js-test.sh
@@ -1,6 +1,4 @@
 #!/bin/bash
 set -eu
 
-./scripts/nargo_compile_noir_js_assert_lt.sh
-rm -rf /usr/src/noir/tooling/noir_js/test/noir_compiled_examples/assert_lt/target/debug_assert_lt.json
-yarn workspace @noir-lang/noir_js test
+yarn workspace @noir-lang/noir_js test
diff --git a/.github/scripts/wasm-bindgen-install.sh b/.github/scripts/wasm-bindgen-install.sh
@@ -1,5 +1,5 @@
 #!/bin/bash
 set -eu
 
-curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh | bash
-cargo-binstall wasm-bindgen-cli --version 0.2.86 -y
+# TODO call this script directly
+./scripts/install_wasm-bindgen.sh
diff --git a/.github/workflows/docs-pr.yml b/.github/workflows/docs-pr.yml
@@ -40,7 +40,7 @@ jobs:
         script: |
           const labels = context.payload.pull_request.labels.map(label => label.name);
           if (!labels.includes('documentation')) {
-            github.issues.addLabels({
+            github.rest.issues.addLabels({
               owner: context.repo.owner,
               repo: context.repo.repo,
               issue_number: context.issue.number,
@@ -54,6 +54,15 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
 
+      - name: Setup toolchain
+        uses: dtolnay/[email protected]
+
+      - uses: Swatinem/rust-cache@v2
+        with:
+          key: x86_64-unknown-linux-gnu
+          cache-on-failure: false
+          save-if: false
+
       - name: Install Yarn dependencies
         uses: ./.github/actions/setup
 

diff --git a/.github/workflows/publish-es-packages.yml b/.github/workflows/publish-es-packages.yml
@@ -15,7 +15,7 @@ on:
 run-name: Publish ES Packages from ${{ inputs.noir-ref }} under @${{ inputs.npm-tag }} tag.
 
 jobs:
-  build-noir_wasm:
+  build-noirc_abi_wasm:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
@@ -32,40 +32,52 @@ jobs:
 
       - name: Build wasm package
         run: |
-          nix build -L .#noir_wasm
+          nix build -L .#noirc_abi_wasm
 
       - uses: actions/upload-artifact@v3
         with:
-          name: noir_wasm
+          name: noirc_abi_wasm
           path: |
-            result/noir_wasm/nodejs
-            result/noir_wasm/web
+            result/noirc_abi_wasm/nodejs
+            result/noirc_abi_wasm/web
 
-  build-noirc_abi_wasm:
+  build-noir_wasm:
+    needs: [build-noirc_abi_wasm]
     runs-on: ubuntu-latest
     steps:
       - name: Checkout sources
         uses: actions/checkout@v4
         with:
           ref: ${{ inputs.noir-ref }}
 
-      - name: Setup Nix
-        uses: ./.github/actions/nix
+      - name: Setup toolchain
+        uses: dtolnay/[email protected]
+
+      - uses: Swatinem/rust-cache@v2
         with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          nix-cache-name: "noir"
-          cachix-auth-token: ${{ secrets.CACHIXAUTHTOKEN }}
-
-      - name: Build wasm package
-        run: |
-          nix build -L .#noirc_abi_wasm
+          key: noir-wasm
+          save-if: false
 
-      - uses: actions/upload-artifact@v3
+      - name: Download noirc_abi_wasm package artifact
+        uses: actions/download-artifact@v3
         with:
           name: noirc_abi_wasm
+          path: ./tooling/noirc_abi_wasm
+
+      - name: Install Yarn dependencies
+        uses: ./.github/actions/setup
+
+      - name: Build noir_wasm
+        run: yarn workspace @noir-lang/noir_wasm build
+
+      - name: Upload artifact
+        uses: actions/upload-artifact@v3
+        with:
+          name: noir_wasm
           path: |
-            result/noirc_abi_wasm/nodejs
-            result/noirc_abi_wasm/web
+            ./compiler/wasm/dist
+            ./compiler/wasm/build
+          retention-days: 3
 
   build-acvm_js:
     runs-on: ubuntu-latest
@@ -97,7 +109,6 @@ jobs:
     runs-on: ubuntu-latest
     needs: [build-acvm_js, build-noirc_abi_wasm, build-noir_wasm]
     steps:
-
       - name: Checkout sources
         uses: actions/checkout@v4
         with:
@@ -107,10 +118,12 @@ jobs:
         with:
           name: acvm_js
           path: acvm-repo/acvm_js
+
       - uses: actions/download-artifact@v3
         with:
           name: noir_wasm
           path: compiler/wasm
+
       - uses: actions/download-artifact@v3
         with:
           name: noirc_abi_wasm

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -11,7 +11,6 @@ jobs:
     outputs:
       release-pr: ${{ steps.release.outputs.pr }}
       tag-name: ${{ steps.release.outputs.tag_name }}
-      pending-release-semver: v${{ steps.release.outputs.major }}.${{steps.release.outputs.minor}}.${{steps.release.outputs.patch}}
     runs-on: ubuntu-latest
     steps:
       - name: Run release-please
@@ -80,9 +79,15 @@ jobs:
       - name: Install Yarn dependencies
         uses: ./.github/actions/setup
 
+      - name: Query new noir version
+        id: noir-version
+        run: |
+          NOIR_VERSION=$(grep '^version =' ./Cargo.toml | sed -E 's/version = "([^"]+)"/v\1/')
+          echo "semver=$NOIR_VERSION" >> $GITHUB_OUTPUT
+
       - name: Cut a new version
         working-directory: ./docs
-        run: yarn docusaurus docs:version ${{ needs.release-please.outputs.pending-release-semver }}
+        run: yarn version ${{ steps.noir-version.outputs.semver }}
 
       - name: Configure git
         run: |
@@ -92,7 +97,7 @@ jobs:
       - name: Commit new documentation version
         run: |
           git add .
-          git commit -m "chore(docs): cut new docs version for tag ${{ needs.release-please.outputs.pending-release-semver }}"
+          git commit -m "chore(docs): cut new docs version for tag ${{ steps.noir-version.outputs.semver }}"
           git push
 
   build-binaries:

diff --git a/.github/workflows/test-js-packages.yml b/.github/workflows/test-js-packages.yml
@@ -247,7 +247,7 @@ jobs:
           yarn workspace @noir-lang/backend_barretenberg test
 
   test-noir-js:
-    needs: [build-acvm-js, build-noirc-abi]
+    needs: [build-nargo, build-acvm-js, build-noirc-abi]
     name: Noir JS
     runs-on: ubuntu-latest
     timeout-minutes: 30
@@ -256,6 +256,12 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v4
 
+      - name: Download nargo binary
+        uses: actions/download-artifact@v3
+        with:
+          name: nargo
+          path: ./nargo
+
       - name: Download artifact
         uses: actions/download-artifact@v3
         with:
@@ -268,6 +274,14 @@ jobs:
           name: noirc_abi_wasm
           path: ./tooling/noirc_abi_wasm
 
+      - name: Set nargo on PATH
+        run: |
+          nargo_binary="${{ github.workspace }}/nargo/nargo"
+          chmod +x $nargo_binary
+          echo "$(dirname $nargo_binary)" >> $GITHUB_PATH
+          export PATH="$PATH:$(dirname $nargo_binary)"
+          nargo -V
+
       - name: Install Yarn dependencies
         uses: ./.github/actions/setup
 

diff --git a/.release-please-manifest.json b/.release-please-manifest.json
@@ -1,4 +1,4 @@
 {
-  ".": "0.22.0",
-  "acvm-repo": "0.38.0"
+  ".": "0.23.0",
+  "acvm-repo": "0.39.0"
 }