Backports to 20.x #268
Closed
Backports to 20.x #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, they can take a negative value (don't really know why because supposedly v8 uses a monotonic clock). We don't want to cast them to unsigned to avoid overflows. PR-URL: #254 Reviewed-By: Juan José Arboleda <[email protected]>
Add `app` field to ZMQ messages. Update appName when it's dynamically changed. PR-URL: #264 Reviewed-By: Juan José Arboleda <[email protected]>
Increase a bit the keepalive period and timeout. Also, set `GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATA` to `0` to make sure we can send `PING` frames indefinitelly even if there's no activity in the channel, to make sure the channel is up for as long as possible. PR-URL: #265 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #256 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #256 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #260 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #180 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-by: Trevor Norris <[email protected]> PR-URL: #260 Reviewed-By: Juan José Arboleda <[email protected]>
To retrieve the opentelemetry-proto version from the MODULE.bazel file. PR-URL: #260 Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #266 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #266 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Make sure the type of the JSON field matches with what's expected to avoid unwanted crashes. PR-URL: #267 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
juanarbol
approved these changes
Feb 13, 2025
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
In some cases, they can take a negative value (don't really know why because supposedly v8 uses a monotonic clock). We don't want to cast them to unsigned to avoid overflows. PR-URL: #254 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
Add `app` field to ZMQ messages. Update appName when it's dynamically changed. PR-URL: #264 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
Increase a bit the keepalive period and timeout. Also, set `GRPC_ARG_HTTP2_MAX_PINGS_WITHOUT_DATA` to `0` to make sure we can send `PING` frames indefinitelly even if there's no activity in the channel, to make sure the channel is up for as long as possible. PR-URL: #265 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
PR-URL: #256 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
PR-URL: #256 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
PR-URL: #260 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
PR-URL: #180 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-by: Trevor Norris <[email protected]> PR-URL: #260 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
To retrieve the opentelemetry-proto version from the MODULE.bazel file. PR-URL: #260 Reviewed-By: Juan José Arboleda <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
PR-URL: #266 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
PR-URL: #266 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #268
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
PR-URL: #268 Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno
added a commit
that referenced
this pull request
Feb 14, 2025
Make sure the type of the JSON field matches with what's expected to avoid unwanted crashes. PR-URL: #267 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> PR-URL: #268
|
Landed in 7a040f6...651bc37 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.