Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agents: improve appName support #264

Closed
wants to merge 1 commit into from

Conversation

santigimeno
Copy link
Member

Add app field to ZMQ messages.
Update appName when it's dynamically changed.

@santigimeno santigimeno requested a review from juanarbol February 3, 2025 11:44
@santigimeno santigimeno self-assigned this Feb 3, 2025
@santigimeno
Copy link
Member Author

Copy link
Contributor

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

Add `app` field to ZMQ messages.
Update appName when it's dynamically changed.
@santigimeno santigimeno force-pushed the santi/appname_tracing branch from 4abfbe7 to 6236a21 Compare February 4, 2025 14:30
@santigimeno santigimeno changed the title test: improve appName support agents: improve appName support Feb 4, 2025
santigimeno added a commit that referenced this pull request Feb 4, 2025
Add `app` field to ZMQ messages.
Update appName when it's dynamically changed.

PR-URL: #264
Reviewed-By: Juan José Arboleda <[email protected]>
@santigimeno
Copy link
Member Author

Landed in 43ed2a4

@santigimeno santigimeno closed this Feb 4, 2025
@santigimeno santigimeno deleted the santi/appname_tracing branch February 4, 2025 14:33
santigimeno added a commit that referenced this pull request Feb 12, 2025
Add `app` field to ZMQ messages.
Update appName when it's dynamically changed.

PR-URL: #264
Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno added a commit that referenced this pull request Feb 14, 2025
Add `app` field to ZMQ messages.
Update appName when it's dynamically changed.

PR-URL: #264
Reviewed-By: Juan José Arboleda <[email protected]>
santigimeno added a commit that referenced this pull request Feb 14, 2025
Add `app` field to ZMQ messages.
Update appName when it's dynamically changed.

PR-URL: #264
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #268
santigimeno added a commit that referenced this pull request Feb 14, 2025
Add `app` field to ZMQ messages.
Update appName when it's dynamically changed.

PR-URL: #264
Reviewed-By: Juan José Arboleda <[email protected]>
PR-URL: #269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants