Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add metrics support for http2 #256

Closed
wants to merge 2 commits into from
Closed

lib: add metrics support for http2 #256

wants to merge 2 commits into from

Conversation

santigimeno
Copy link
Member 

lib: add diagnostic channels to http2

lib: add metrics support for http2

@santigimeno santigimeno self-assigned this Jan 21, 2025
juanarbol
juanarbol approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to say, but based on the shape, this is looking good to me.

@santigimeno santigimeno force-pushed the santi/diag_http2 branch 3 times, most recently from aae15a1 to 106d9e8 Compare January 22, 2025 11:14
RafaelGSS
RafaelGSS approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/internal/http2/core.js Outdated Show resolved Hide resolved
@santigimeno santigimeno force-pushed the santi/diag_http2 branch 3 times, most recently from 49d2225 to ad78768 Compare January 24, 2025 17:42
@santigimeno
Copy link
Member Author

Fixes: https://github.com/nodesource/nsolid-roadmap/issues/12

santigimeno added a commit that referenced this pull request Feb 11, 2025
@santigimeno
lib: add diagnostic channels to http2
6350b95 
PR-URL: #256
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno added a commit that referenced this pull request Feb 11, 2025
@santigimeno
lib: add metrics support for http2
4ded43b 
PR-URL: #256
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@santigimeno
Copy link
Member Author

Landed in 30f54e6...4ded43b

santigimeno added a commit that referenced this pull request Feb 12, 2025
@santigimeno
lib: add diagnostic channels to http2
52316d3 
PR-URL: #256
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno added a commit that referenced this pull request Feb 12, 2025
@santigimeno
lib: add metrics support for http2
4c7fc37 
PR-URL: #256
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno added a commit that referenced this pull request Feb 14, 2025
@santigimeno
lib: add diagnostic channels to http2
9f304a2 
PR-URL: #256
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno added a commit that referenced this pull request Feb 14, 2025
@santigimeno
lib: add metrics support for http2
911d4fd 
PR-URL: #256
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
santigimeno added a commit that referenced this pull request Feb 14, 2025
@santigimeno
lib: add diagnostic channels to http2
d73b8f0 
PR-URL: #256
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #268
santigimeno added a commit that referenced this pull request Feb 14, 2025
@santigimeno
lib: add metrics support for http2
96edafa 
PR-URL: #256
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #268
santigimeno added a commit that referenced this pull request Feb 14, 2025
@santigimeno
lib: add diagnostic channels to http2
a61dc8b 
PR-URL: #256
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #269
santigimeno added a commit that referenced this pull request Feb 14, 2025
@santigimeno
lib: add metrics support for http2
5208d16 
PR-URL: #256
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: #269
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

@santigimeno santigimeno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@santigimeno @juanarbol @RafaelGSS