Added support for 5.x and some refactoring. #19
Conversation
* Added and tested new NodeJS version * Added a more extensible way of catering for the original 0.10, 0.12, along with support for 4.x and 5.x repo paths
wolfeidau
force-pushed
the
add_support_for_nodejs_5.x
branch
2 times, most recently
from
c12c658 to
44bc4e7
Compare
|
Looking for feedback on this from @Yanchek99 or @tphummel. Does this look like a suitable way to deal with 0.10/0.12/4.x/5.x and more in the future? Cheers |
| # 0.10 or 0.12 or 4.x | ||
| nodejs_version: "4.2" | ||
| # 0.10 or 0.12 or 4.x or 5.x | ||
| nodejs_version: "5.0" |
There was a problem hiding this comment.
perhaps set this to 5.x for consistency?
There was a problem hiding this comment.
The idea here is you can currently install a specific release, and it is then translated to the 5.x or 4.x required to build the repo path.
We could just get people to enter 0.10, 0.12 or 4.x or 5.x ect.
Actually seems like a better move.
There was a problem hiding this comment.
Scratch that, we require 5.x for the repo name, and a numeric value 5.0 for the apt task install.
|
Would be nice to refactor the tests to check each major version. 0.10, 0.12, 4.x, and 5.x |
|
@Yanchek99 I have had a look at testing ansible before and it is a bit of a mixed bag. I will remove the debug statement and have a look around at some way to at least asset the intended version is installed in the playbook used for testing. Cheers. |
wolfeidau
force-pushed
the
add_support_for_nodejs_5.x
branch
from
44bc4e7 to
c60b5d5
Compare
No description provided.