Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: expose urlpattern as global #56950

Merged
merged 1 commit into from
Feb 9, 2025
Merged

url: expose urlpattern as global #56950

merged 1 commit into from
Feb 9, 2025

Conversation

JonasBa
Copy link
Contributor

@JonasBa JonasBa commented Feb 7, 2025

Expose URLPattern as global.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Feb 7, 2025
@anonrig anonrig added semver-major PRs that contain breaking changes and should be released in the next major version. notable-change PRs with changes that should be highlighted in changelogs. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @anonrig.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

@anonrig anonrig requested review from panva and jasnell February 7, 2025 15:28
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 7, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 7, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/65049/ 💚

@codecov Codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.13%. Comparing base (048a17a) to head (a3d06c6).
Report is 20 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56950      +/-   ##
==========================================
- Coverage   89.15%   89.13%   -0.02%     
==========================================
  Files         665      665              
  Lines      192846   192848       +2     
  Branches    37145    37143       -2     
==========================================
- Hits       171926   171902      -24     
  Misses      13696    13696              
- Partials     7224     7250      +26
Files with missing lines Coverage Δ
...internal/bootstrap/web/exposed-window-or-worker.js 93.79% <100.00%> (+0.09%) ⬆️

... and 16 files with indirect coverage changes

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 7, 2025
@anonrig
Copy link
Member

anonrig commented Feb 7, 2025

cc @nodejs/tsc this requires 2 TSC approval to land since it is a semver-major PR

mcollina
mcollina approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit d1f8ccb into nodejs:main Feb 9, 2025
78 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d1f8ccb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@mcollina mcollina mcollina approved these changes

@panva panva panva approved these changes

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JonasBa @nodejs-github-bot @anonrig @mcollina @panva @jasnell @targos @KhafraDev