Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.x backport] src: add --env-file-if-exists flag #56932

Open
wants to merge 3 commits into
base: v20.x-staging
Choose a base branch
from
Open

[20.x backport] src: add --env-file-if-exists flag #56932

wants to merge 3 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 5, 2025 •
edited
Loading

@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 5, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Feb 5, 2025
@marco-ippolito
Copy link
Member

Why are we backporting a semver minor to v20.x?

@aduh95
Copy link
Contributor Author

aduh95 commented Feb 6, 2025

Why are we backporting a semver minor to v20.x?

I can't talk for anyone besides my own self, the reason I'm opening this backport PR is that I'd like to see it landed on 20.x. I believe there's a plan for an upcoming semver-minor 20.x release, so I'm hopeful this could be a part of it.

avivkeller and others added 2 commits February 6, 2025 18:33
@avivkeller @xduugu @aduh95
src: don't match after -- in Dotenv::GetPathFromArgs
37169e4 
Co-Authored-By: Cedric Staniewski <[email protected]>
PR-URL: nodejs#54237
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@BoscoDomingo @aduh95
src: add --env-file-if-exists flag
c4e38c4 
Fixes: nodejs#50993
Refs: nodejs#51451

test: remove unnecessary comment

src: conform to style guidelines

src: change flag to `--env-file-optional`

test: revert automatic linter changes

doc: fix typos

src: change flag to `--env-file-if-exists`

src: refactor `env_file_data` and `GetEnvFileDataFromArgs`

test: clean up tests

src: print error when file not found

test: remove unnecessary extras
PR-URL: nodejs#53060
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95 aduh95 force-pushed the env-file-if-exists-20.x branch from 1d708fb to c4e38c4 Compare February 6, 2025 17:34
@juanarbol
Copy link
Member

Maybe also this one? #56893

@juanarbol @aduh95
doc: mark --env-file-if-exists flag as experimental
ab56ae8 
As `--env-file` is experimental, this must be marked as experimental as
well.

Refs: nodejs#56887
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: nodejs#56893
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @marco-ippolito @juanarbol @avivkeller @BoscoDomingo