module: use more defensive code when handling SWC errors

[aduh95]

In case the thrown error is not of the shape we expect, we get a TypeError but an ERR_INTERNAL_ASSERTION

[nodejs-github-bot]

Review requested:

• @nodejs/loaders

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.20%. Comparing base (2e45656) to head (7c1116a).
Report is 24 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/modules/typescript.js	50.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #56646      +/-   ##
==========================================
- Coverage   89.21%   89.20%   -0.02%     
==========================================
  Files         662      662              
  Lines      191883   191886       +3     
  Branches    36941    36932       -9     
==========================================
- Hits       171196   171176      -20     
- Misses      13536    13547      +11     
- Partials     7151     7163      +12     

Files with missing lines	Coverage Δ
lib/internal/modules/typescript.js	97.05% <50.00%> (-0.55%)	⬇️

... and 36 files with indirect coverage changes

[marco-ippolito]

Not sure whats the benefit. That path should be unreachable. If it goes into the default it means its a bug or misuse of internals so user should report it.

[aduh95]

Not sure whats the benefit. That path should be unreachable. If it goes into the default it means its a bug or misuse of internals so user should report it.

Yes exactly, hence the added assertion: if the thrown object is not of the shape we expect, we should throw an assertion fail (the current code assumes it's going to be of a certain shape)

[marco-ippolito]

ERR_INTERNAL_ASSERTION adds the

This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
Please open an issue with this stack trace at 

Which is useful imho because it tells the user to open an issue and allows us to find bugs, while the normal assert is not so descriptive.

[aduh95]

I know, this PR doesn't change that

node/lib/internal/assert.js

Lines 15 to 20 in 7178588

	function fail(message) {
	const ERR_INTERNAL_ASSERTION = lazyError();
	throw new ERR_INTERNAL_ASSERTION(message);
	}
	assert.fail = fail;

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64636/

[nodejs-github-bot]

Landed in 905e4b4