worker: flush stdout and stderr on exit #56428
Open
+31
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <[email protected]>
Signed-off-by: Matteo Collina <[email protected]>
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56428 +/- ##
========================================
Coverage 88.54% 88.55%
========================================
Files 657 657
Lines 190393 190745 +352
Branches 36552 36612 +60
========================================
+ Hits 168582 168908 +326
- Misses 14998 15024 +26
Partials 6813 6813
|
jasnell
approved these changes
Jan 2, 2025
ShogunPanda
approved these changes
Jan 2, 2025
climba03003
reviewed
Jan 2, 2025
| @@ -292,6 +292,9 @@ class WritableWorkerStdio extends Writable { | |||
| chunks: ArrayPrototypeMap(chunks, | |||
| ({ chunk, encoding }) => ({ chunk, encoding })), | |||
| }); | |||
| if (process._exiting) { | |||
| cb() | |||
| } | |||
| ArrayPrototypePush(this[kWritableCallbacks], cb); | |||
There was a problem hiding this comment.
Will there be problems when the callback being called twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix an old problem I had since forever when using worker threads, stdout log lines being cut if the thread exited. This PR fixes it by bypassing backpressure if the thread is exiting.