src: set signal inspector io thread name

PR-URL: #56416 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
nodejs · Feb 6, 2025 · 8507b55 · 8507b55
1 parent 124597b
commit 8507b55
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/doc/api/worker_threads.md b/doc/api/worker_threads.md
@@ -1237,7 +1237,9 @@ changes:
     * Maximum sizes:
       * Windows: 32,767 characters
       * macOS: 64 characters
-      * Other systems: 16 characters
+      * Linux: 16 characters
+      * NetBSD: limited to `PTHREAD_MAX_NAMELEN_NP`
+      * FreeBSD and OpenBSD: limited to `MAXCOMLEN`
         **Default:** `'WorkerThread'`.
 
 ### Event: `'error'`

diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -86,6 +86,7 @@ static void StartIoThreadWakeup(int signo, siginfo_t* info, void* ucontext) {
 }
 
 inline void* StartIoThreadMain(void* unused) {
+  uv_thread_setname("SignalInspector");
   for (;;) {
     uv_sem_wait(&start_io_thread_semaphore);
     Mutex::ScopedLock lock(start_io_thread_async_mutex);

diff --git a/src/inspector_io.cc b/src/inspector_io.cc
@@ -286,7 +286,7 @@ void InspectorIo::ThreadMain() {
   int thread_name_error = uv_thread_setname("InspectorIo");
   if (!thread_name_error) [[unlikely]] {
     per_process::Debug(node::DebugCategory::INSPECTOR_SERVER,
-        "Failed to set thread name for Inspector\n");
+                       "Failed to set thread name for Inspector\n");
   }
   uv_loop_t loop;
   loop.data = nullptr;