Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily skip t5 data dependent tests to unblock CI as I figure out how to add things one by one #918

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −6
Open

Temporarily skip t5 data dependent tests to unblock CI as I figure out how to add things one by one #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
195e2d3
Bump IREE to 3.2.0rc20250129.
github-actions[bot] Jan 29, 2025
295530c
Merge branch 'main' into integrates/iree
renxida Jan 30, 2025
9707858
remove t5 data-dependent tests for now
renxida Feb 5, 2025
99ddd73
Merge branch 'integrates/iree' of https://github.com/nod-ai/shark-ai …
renxida Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci-sharktank.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ jobs:
pytest \
--with-clip-data \
--with-flux-data \
--with-t5-data \
--with-vae-data \
--with-quark-data \
sharktank/tests/models/clip/clip_test.py \
Expand All @@ -149,7 +148,9 @@ jobs:
sharktank/tests/models/llama/quark_parity_test.py \
--durations=0 \
--timeout=800
# TODO: add back
# --with-t5-data \
# when #888 is resolved

test_integration:
name: "Model Integration Tests"
Expand Down
6 changes: 3 additions & 3 deletions requirements-iree-pinned.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

# Keep these versions synced with SHORTFIN_IREE_GIT_TAG in shortfin/CMakeLists.txt
--find-links https://iree.dev/pip-release-links.html
iree-base-compiler==3.2.0rc20250120
iree-base-runtime==3.2.0rc20250120
iree-turbine==3.2.0rc20250121
iree-base-compiler==3.2.0rc20250129
iree-base-runtime==3.2.0rc20250129
Comment on lines -5 to +6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mention these changes in the PR title:

"Update IREE to 3.2.0rc20250129 and disable t5 tests."

Then also link to #888 in the PR body. I can't really tell from the logs and issue... was t5 the test that failed? Or flux? Or clip? The issue mentions problems in a few tests...

iree-turbine==3.2.0rc20250129
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync this with d33ef0b to not move back a version

Suggested change
iree-turbine==3.2.0rc20250129
iree-turbine==3.2.0rc20250205

2 changes: 1 addition & 1 deletion shortfin/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ add_compile_options("$<$<CXX_COMPILER_ID:MSVC>:/utf-8>")
# Prefer to keep the IREE git tag synced with the Python package version in the
# requirements-iree-pinned.txt file. At a minimum, the compiler from those
# packages must be compatible with the runtime at this source ref.
set(SHORTFIN_IREE_GIT_TAG "iree-3.2.0rc20250120")
set(SHORTFIN_IREE_GIT_TAG "iree-3.2.0rc20250129")


# build options
Expand Down
Loading