Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shortfin] SD server indexing fix #892

Merged
merged 3 commits into from
Feb 3, 2025
Merged

[Shortfin] SD server indexing fix #892

merged 3 commits into from
Feb 3, 2025

Conversation

IanNod
Copy link
Contributor

@IanNod IanNod commented Jan 31, 2025

Fixes a bug in the sd server that was not connecting the appropriate fibers to workers resulting in unbalanced workers threads

@IanNod IanNod marked this pull request as draft January 31, 2025 02:51
@IanNod IanNod marked this pull request as ready for review January 31, 2025 22:57
jinchen62
jinchen62 approved these changes Feb 1, 2025
View reviewed changes
Copy link
Contributor

@jinchen62 jinchen62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@IanNod IanNod merged commit c10a5de into nod-ai:main Feb 3, 2025
36 of 37 checks passed
@IanNod IanNod deleted the fix_worker_idx branch February 3, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinchen62 jinchen62 jinchen62 approved these changes

@monorimet monorimet Awaiting requested review from monorimet

@stellaraccident stellaraccident Awaiting requested review from stellaraccident

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanNod @jinchen62