Move server-specific config args out of ModelParams and into new ServerParams in config_struct.py #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renxida
force-pushed
the
move-prefix-sharing-algo-out-of-model-config
branch
2 times, most recently
from
fd72536 to
4a83957
Compare
renxida
force-pushed
the
move-prefix-sharing-algo-out-of-model-config
branch
from
197fa67 to
2d3d198
Compare
renxida
force-pushed
the
move-prefix-sharing-algo-out-of-model-config
branch
from
2d3d198 to
2e2911b
Compare
renxida
changed the title
stbaione
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, prefix sharing is read as a config key from the exported-model's config.json.
There is no reason for it to be there - - this is not a property of the model, but rather a property of the server instance that's being launched.
This overcomplicates the tests: rather than just inserting an additional cmdline arg, the tests have to make an edited copy of the exported config files in order to specify the prefix-sharing algorithm.
Solution
This PR puts in a ServerParam class for storing config options that don't require re-exporting the model. Right now it just affects the prefix-sharing algorithm but this makes space for things like:
Why this?
Deepseek v3 will have many run-time options that aren't relevant at export/compile, e.g. MTP. These changes will make it easier to set those up.