Fix/skip trie_attention_cache_test on Windows. #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScottTodd
changed the title
ScottTodd
commented
Dec 4, 2024
Comment on lines
+93
to
+95
| def __lt__(self, other): | ||
| """Sort nodes by their memory address.""" | ||
| return id(self) < id(other) |
There was a problem hiding this comment.
If the tests passed on Linux without this and they still fail on Windows with it... maybe this isn't the right implementation 🤔
Could leave this off and just keep the test skipped.
|
Ping? |
renxida
approved these changes
Dec 5, 2024
renxida
force-pushed
the
windows-tests
branch
from
5479a28 to
d6cbf27
Compare
So are you okay with merging this as-is, or do you want some changes to the heapq code? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #632 (comment)