In LLM export make dynamic dims compatible with non-defaults #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-garvey
approved these changes
Oct 31, 2024
sogartar
force-pushed
the
llm-export-dynamic-dims-with-non-defaults
branch
from
c37a84b to
adbaf83
Compare
sogartar
force-pushed
the
llm-export-dynamic-dims-with-non-defaults
branch
from
adbaf83 to
6dfc7a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests for toy-sized sharded Llama that I want to adapt to use this script have non-default values. The export chokes on them.