Feature/add frequency tolerance parameter #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCFurry
reviewed
Aug 1, 2022
velodyne_driver/cfg/VelodyneNode.cfg
Outdated
| @@ -11,5 +11,6 @@ gen = ParameterGenerator() | |||
| gen.add("time_offset", double_t, 1, "A manually calibrated offset (in seconds) to add to the timestamp before publication of a message.", | |||
| 0.0, -1.0, 1.0) | |||
| gen.add("enabled", bool_t, 2, "Switch to enable and disable lidar packet consumption", True); | |||
There was a problem hiding this comment.
Maybe make the window_size also a parameter then?
There was a problem hiding this comment.
I think we get enough control with the tolerance parameter and a fixed window size of 10, my preference would go for less parameters
MCFurry
reviewed
Aug 1, 2022
MCFurry
approved these changes
Aug 2, 2022
Timple
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR only for internal review, after approval I will create a PR to the base repo.