Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: my lists page #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

iamsaumya
Copy link
Contributor

Update the /my-lists page to show a user's lists.

Noam, I did the bare minimum to render the lists. I have a few doubts before I polish it further.

  • Should I build the whole list flow and then focus on styles? or keep the focus on styling at every step.
  • Any thoughts on adding prettier or some standard formatting to the codebase?
  • I noticed that the nextjs app uses v4 API. v3 has a lack of data. Any thoughts on porting to v4?

@vercel
Copy link

vercel bot commented Dec 10, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @noamr on Vercel.

@noamr first needs to authorize it.

@noamr
Copy link
Owner

noamr commented Dec 10, 2022

Update the /my-lists page to show a user's lists.

Noam, I did the bare minimum to render the lists. I have a few doubts before I polish it further.

  • Should I build the whole list flow and then focus on styles? or keep the focus on styling at every step.

It's up to you... maybe build the flow first and slowly make the styles better?

  • Any thoughts on adding prettier or some standard formatting to the codebase?

Great idea! I didn't get to it yet, feel free to PR.

  • I noticed that the nextjs app uses v4 API. v3 has a lack of data. Any thoughts on porting to v4?

Also a good idea.

For all of the above, go in whatever pace you like...

<a href="#">
<div class="listCard">
<h2></h2>
<span></span>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be better to give it a class, like "listMovieCount". We use the tag names when it's clear-ish what they're for (e.g. headings, nav)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants