[Windows] Simplify iniparser import #2883
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use most standrard meson way to import cmake iniparser library This way of importing wil work regardless of operating system **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Grzegorz Kisala <[email protected]>
gkisalapl
force-pushed
the
iniparser_import
branch
from
01cec45 to
bf77046
Compare
Signed-off-by: Grzegorz Kisala <[email protected]>
gkisalapl
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang,
dkjung and
haehun
as code owners
DonghakPark
reviewed
Jan 18, 2025
myungjoo
requested changes
Jan 18, 2025
There was a problem hiding this comment.
You are breaking non Windows build here. (there are distros not allowing external repos)
In most Linux distros, you are supposed to build with the packages available inside the distro, not from external repositories. For embedded deviecs, the principle is the same; you share the same library (iniparse in this case) with all the other packages in the system.
You may conditionally import the wrap-git if iniparser is not found by pkg-config (dependnecy('iniparser', ...))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use most standard meson way to import cmake iniparser library This way of importing will work regardless of operating system
Self-evaluation: