Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blas] copy functionality for signed int16 data type #2876

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

djeong20
Copy link
Contributor

This pull request aims to add the functionality of copying the int16 data type into fp32.
Please note that this implementation does not utilize SIMD at this time.

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Copy link
Contributor

@baek2sm baek2sm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This pull request aims to add the functionality of copying the int16 data type into fp32.
Please note that this implementation does not utilize SIMD at this time.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
@djeong20 djeong20 force-pushed the backend/cpu/copy/int16 branch from 1cb48bc to 8f105ca Compare January 15, 2025 07:42
Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will implement neon kernel after this PR.

Copy link
Member

@DonghakPark DonghakPark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@djeong20 djeong20 changed the title [Wait for #2866][Blas] copy functionality for signed int16 data type [Blas] copy functionality for signed int16 data type Jan 16, 2025
@jijoongmoon jijoongmoon merged commit ee3b1d5 into nnstreamer:main Jan 17, 2025
24 checks passed
@djeong20 djeong20 deleted the backend/cpu/copy/int16 branch January 22, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants