[Tensor] Proposal for unifying tensor addition: remove add_i implementation #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation This pull request proposes the removal of the add_i implementation and its unification with the add function. Currently, the use of two distinct kernels for tensor addition can result in performance inefficiencies. To enhance overall performance, it is crucial to address this issue. Additionally, we will need to undertake follow-up work to successfully integrate ele_add and sxapy. **Self-evaluation:** 1. Build test: [X]Passed [ ]Failed [ ]Skipped 2. Run test: [X]Passed [ ]Failed [ ]Skipped Signed-off-by: Donghyeon Jeong <[email protected]>
djeong20
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8 and
EunjuYang
as code owners
skykongkong8
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Suggestion for the follow-up work proposed from here is at #2862
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes the removal of the add_i implementation and its unification with the add function.
Currently, the use of two distinct kernels for tensor addition can result in performance inefficiencies.
To enhance overall performance, it is crucial to address this issue.
Additionally, we must undertake follow-up work to integrate ele_add and sxapy successfully.
Self-evaluation: