Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wait for #2846][FSU] Modify Load Logic at FSU @open sesame 01/07 09:50 #2854

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DonghakPark
Copy link
Member

The process of loading trained weights during inference in NNTrainer currently uses model->load(). (before call inference)

However, since FSU loads weights from flash memory according to the required layers up to the specified look-ahead value, we need to prevent weights from being loaded before inference.

To reflect this change, I modified the code in LayerNode and added a new parameter called swap_parm.

commit summary
commit 1 [Application] Update FSU SimpleFC Application : update SimpleFC Application for more easy test & actual environment
commit 2 [FSU] update layer weight load logic at fsu : update layernode not to load weight at load()

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK [email protected]

Update FSU SimpleFC Application for real case

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
at case of fsu, layer's load not needed
- add swap parm
- when swap enabled : load not work
- update SimpleFC Application

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghak PARK <[email protected]>
@DonghakPark DonghakPark changed the title [Wait for #2846][FSU] Modify Load Logic at FSU [Wait for #2846][FSU] Modify Load Logic at FSU @open sesame 01/06 12:16 Jan 6, 2025
@DonghakPark DonghakPark self-assigned this Jan 6, 2025
@DonghakPark DonghakPark changed the title [Wait for #2846][FSU] Modify Load Logic at FSU @open sesame 01/06 12:16 [Wait for #2846][FSU] Modify Load Logic at FSU @open sesame 01/06 16:56 Jan 6, 2025
@DonghakPark DonghakPark changed the title [Wait for #2846][FSU] Modify Load Logic at FSU @open sesame 01/06 16:56 [Wait for #2846][FSU] Modify Load Logic at FSU @open sesame 01/07 19:50 Jan 7, 2025
@DonghakPark DonghakPark changed the title [Wait for #2846][FSU] Modify Load Logic at FSU @open sesame 01/07 19:50 [Wait for #2846][FSU] Modify Load Logic at FSU @open sesame 01/07 09:50 Jan 7, 2025
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 3 days.

@github-actions github-actions bot added the Stale label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant