Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wait for #2536][application] add generate_multiple_tokens for llm @open sesame 04/05 16:14 #2540

Merged
merged 1 commit into from
May 2, 2024
Merged

[Wait for #2536][application] add generate_multiple_tokens for llm @open sesame 04/05 16:14 #2540

merged 1 commit into from
May 2, 2024

Conversation

baek2sm
Copy link
Contributor

@baek2sm baek2sm commented Apr 5, 2024

Added generate_multiple_tokens function for first generation on llm.

This function takes one logits and generates multiple output tokens.
To meet the purpose of the target application,
even if input are multiple logits,
only the first logits is used to generate multiple output tokens.

Self evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

@taos-ci
Copy link

taos-ci commented Apr 5, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2540. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@taos-ci
Copy link

taos-ci commented Apr 5, 2024

:octocat: cibot: @baek2sm, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2540-202404051420140.12845396995544-9b084590641606c09502ef79096695d67cd0c0db/.

jijoongmoon
jijoongmoon approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dkjung
dkjung reviewed Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@dkjung dkjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dkjung
dkjung approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@dkjung dkjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taos-ci
Copy link

taos-ci commented Apr 5, 2024

:octocat: cibot: @baek2sm, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2540-202404051521080.72869992256165-23e5df0a40b07abae40e9bd2133689a0a97f7c3c/.

@baek2sm baek2sm changed the title [Wait for #2536][application] add generate_multiple_tokens for llm [Wait for #2536][application] add generate_multiple_tokens for llm @open sesame 04/05 16:14 Apr 5, 2024
@taos-ci
Copy link

taos-ci commented Apr 5, 2024

:octocat: cibot: @baek2sm, A builder checker could not be completed because one of the checkers is not completed. In order to find out a reason, please go to http://ci.nnstreamer.ai/nntrainer/ci/repo-workers/pr-checker/2540-202404051613580.66992688179016-23e5df0a40b07abae40e9bd2133689a0a97f7c3c/.

taos-ci
taos-ci approved these changes Apr 5, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

taos-ci
taos-ci approved these changes Apr 6, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

jijoongmoon
jijoongmoon approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@jijoongmoon jijoongmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

skykongkong8
skykongkong8 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@skykongkong8 skykongkong8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SeoHyungjun
SeoHyungjun approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@SeoHyungjun SeoHyungjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

djeong20
djeong20 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@djeong20 djeong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! please rebase to resolve the conflict.

EunjuYang
EunjuYang approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@EunjuYang EunjuYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lhs8928
lhs8928 requested changes Apr 19, 2024
View reviewed changes
@baek2sm baek2sm force-pushed the generate_init branch 2 times, most recently from 16c2324 to 96c6944 Compare April 26, 2024 06:43
@baek2sm
[Wait for nnstreamer#2536][application] add generate_multiple_tokens …
a013650 
…for llm

Added generate_multiple_tokens function for first generation on llm.

This function takes one logits and generates multiple output tokens.
To meet the purpose of the target application,
even if input are multiple logits,
only the first logits is used to generate multiple output tokens.

**Self evaluation:**
1. Build test:	 [X]Passed [ ]Failed [ ]Skipped
2. Run test:	 [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Seungbaek Hong <[email protected]>
taos-ci
taos-ci approved these changes Apr 26, 2024
View reviewed changes
Copy link

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baek2sm, 💯 All CI checkers are successfully verified. Thanks.

lhs8928
lhs8928 approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@lhs8928 lhs8928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jijoongmoon jijoongmoon merged commit 3d9556b into nnstreamer:main May 2, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkjung dkjung dkjung approved these changes

@EunjuYang EunjuYang EunjuYang approved these changes

@jijoongmoon jijoongmoon jijoongmoon approved these changes

@lhs8928 lhs8928 lhs8928 approved these changes

@SeoHyungjun SeoHyungjun SeoHyungjun approved these changes

@taos-ci taos-ci taos-ci approved these changes

@djeong20 djeong20 djeong20 approved these changes

@skykongkong8 skykongkong8 skykongkong8 approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@jaeyun-jung jaeyun-jung Awaiting requested review from jaeyun-jung jaeyun-jung is a code owner

@leemgs leemgs Awaiting requested review from leemgs leemgs is a code owner

@wooksong wooksong Awaiting requested review from wooksong wooksong is a code owner

@helloahn helloahn Awaiting requested review from helloahn

@kparichay kparichay Awaiting requested review from kparichay

@gichan-jang gichan-jang Awaiting requested review from gichan-jang gichan-jang is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

@zhoonit zhoonit Awaiting requested review from zhoonit

@songgot songgot Awaiting requested review from songgot songgot is a code owner

@jihochu jihochu Awaiting requested review from jihochu jihochu is a code owner

@DonghakPark DonghakPark Awaiting requested review from DonghakPark DonghakPark is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@baek2sm @taos-ci @dkjung @EunjuYang @jijoongmoon @lhs8928 @SeoHyungjun @djeong20 @skykongkong8