[OpenCL/GPU] Kernel binary caching @open sesame 04/04 09:22 #2503
Conversation
Added utilities for saving kernel as binary files. Added wrapper for clCreateProgramWithBinary. Signed-off-by: Debadri Samaddar <[email protected]>
s-debadri
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
helloahn,
kparichay,
gichan-jang,
anyj0527,
zhoonit,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun,
baek2sm,
skykongkong8,
djeong20,
EunjuYang and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #2503. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/. |
|
|
cibot: 
There was a problem hiding this comment.
@s-debadri, 💯 All CI checkers are successfully verified. Thanks.
s-debadri
changed the title
Used better C++ paradigm to enhance readability. Added proper cleanup stub. Signed-off-by: Debadri Samaddar <[email protected]>
|
|
There was a problem hiding this comment.
@s-debadri, 💯 All CI checkers are successfully verified. Thanks.
s-debadri
changed the title
nntrainer/opencl/opencl_program.cpp
Outdated
| // Write the binary to file | ||
| // All kernels in the program will be saved in the binary file | ||
| for (unsigned int i = 0; i < num_devices; ++i) { | ||
| std::ofstream fs(std::string(kernel_names) + "_kernel.bin", |
There was a problem hiding this comment.
It needs to get a parameter save path like kernel_path + ... which can be defined by option.
There was a problem hiding this comment.
Incorporated opencl-kernel-path pre-processor directive in latest commit
| @@ -29,8 +31,8 @@ namespace nntrainer::opencl { | |||
| * @return true if successful or false otherwise | |||
There was a problem hiding this comment.
It would be better to add a comment for @param binaryCreated
There was a problem hiding this comment.
Added in latest commit.
Added opencl-kernel-path preprocessor directive and handled inside opencl_program. Signed-off-by: Debadri Samaddar <[email protected]>
|
|
|
|
Add DEFAULT_KERNEL_PATH as static member of Program class Modified macros for stringification Signed-off-by: Debadri Samaddar <[email protected]>
|
|
There was a problem hiding this comment.
@s-debadri, 💯 All CI checkers are successfully verified. Thanks.
|
@EunjuYang @jihochu PTAL. This is taking too long. |
|
could you check the CI? |
DonghakPark
changed the title
|
|
It means that there are too many conditional compilation directives (#ifdef and others) in the code being analyzed. Cppcheck can handle up to 12 such configurations at a time by default and i give --force option and run in my local environment --> There is no cppcheck error on this PR |
There was a problem hiding this comment.
@s-debadri, 💯 All CI checkers are successfully verified. Thanks.
Changes for GPU kernel caching:
clGetProgramInfo.clCreateProgramWithBinary.Signed-off-by: Debadri Samaddar [email protected]