Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Custom] Support custom connection #212

Merged
merged 3 commits into from
Aug 21, 2024
Merged

[Custom] Support custom connection #212

merged 3 commits into from
Aug 21, 2024

Conversation

gichan-jang
Copy link
Member

@gichan-jang gichan-jang commented Aug 16, 2024 •
edited
Loading

User can define their own connection method using custom connection.
nns_edge_custom_create_handle is added to create custom edge handle.
libnnstreamer-edge-custom.so is made only for test.

Self evaluation:

  1. Build test: [ ]Passed [ ]Failed [*]Skipped
  2. Run test: [ ]Passed [ ]Failed [*]Skipped

@gichan-jang
Add skeleton code for custom connection
7acb4ce 
User can create tehir own connection type using custom connection.

Signed-off-by: gichan2-jang <[email protected]>
@taos-ci
Copy link
Collaborator

taos-ci commented Aug 16, 2024

📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #212. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://ci.nnstreamer.ai/.

@gichan-jang
[Custom] Implement custom connection
017173f 
Implement custom connection
@todo: Add unit test case

Signed-off-by: gichan2-jang <[email protected]>
taos-ci
taos-ci approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

@songgot
Copy link
Contributor

songgot commented Aug 16, 2024 •
edited
Loading

About tests/nnstreamer-edge-custom.c.
The functions are short and follow the single responsibility principle well. Great. 👏

@taos-ci
Copy link
Collaborator

taos-ci commented Aug 20, 2024

:octocat: cibot: @gichan-jang, include/nnstreamer-edge-custom.h does not include Doxygen tags such as @file @brief @author @bug. You must include the Doxygen tags in the source code. Please refer to a Doxygen manual at http://github.com/nnstreamer/TAOS-CI/blob/main/ci/doc/doxygen-documentation.md

@gichan-jang gichan-jang force-pushed the custom/connection branch 2 times, most recently from 9967c90 to e78569b Compare August 20, 2024 06:39
taos-ci
taos-ci approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

taos-ci
taos-ci approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

jaeyun-jung
jaeyun-jung reviewed Aug 20, 2024
View reviewed changes
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@gichan-jang gichan-jang force-pushed the custom/connection branch 2 times, most recently from 7b8b675 to 70dce85 Compare August 21, 2024 00:22
@gichan-jang
[TEST] Add unit test for custom connection
76acd01 
Add unit test for custom connection
*linnnstreamer-edge-cusom.so is not real implementation just for test

Signed-off-by: gichan2-jang <[email protected]>
taos-ci
taos-ci approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@taos-ci taos-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gichan-jang, 💯 All CI checkers are successfully verified. Thanks.

songgot
songgot approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@songgot songgot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jaeyun-jung jaeyun-jung merged commit 3581d10 into nnstreamer:main Aug 21, 2024
32 checks passed
@gichan-jang gichan-jang deleted the custom/connection branch November 12, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taos-ci taos-ci taos-ci approved these changes

@jaeyun-jung jaeyun-jung jaeyun-jung approved these changes

@songgot songgot songgot approved these changes

@myungjoo myungjoo Awaiting requested review from myungjoo myungjoo is a code owner

@jijoongmoon jijoongmoon Awaiting requested review from jijoongmoon jijoongmoon is a code owner

@again4you again4you Awaiting requested review from again4you again4you is a code owner

@anyj0527 anyj0527 Awaiting requested review from anyj0527 anyj0527 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gichan-jang @taos-ci @songgot @jaeyun-jung