Skip to content

Commit

Permalink
feat(generator): use electron v9 by default
Browse files Browse the repository at this point in the history
  • Loading branch information
nklayman committed May 23, 2020
1 parent dfde39c commit 261b78e
Show file tree
Hide file tree
Showing 6 changed files with 1,991 additions and 2,033 deletions.
2 changes: 1 addition & 1 deletion __tests__/createProject.helper.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const createProject = (projectName, useTS, customPlugins = {}) =>
preset.plugins['vue-cli-plugin-electron-builder'] = {
// electron-builder requires that an exact version of electron is provided,
// unless electron is already installed
electronBuilder: { electronVersion: '8.0.0' }
electronBuilder: { electronVersion: '9.0.0' }
}
preset.plugins = { ...preset.plugins, ...customPlugins }
const projectPath = p =>
Expand Down
2 changes: 1 addition & 1 deletion __tests__/generator.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ beforeEach(() => {
jest.clearAllMocks()
})
const runGenerator = () =>
generator(mockApi, { electronBuilder: { electronVersion: '^8.0.0' } })
generator(mockApi, { electronBuilder: { electronVersion: '^9.0.0' } })

describe('.gitignore', () => {
test('extends gitignore if it exists', () => {
Expand Down
2 changes: 1 addition & 1 deletion __tests__/mock_package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"isMock": true,
"devDependencies": {
"electron": "^8.0.0"
"electron": "^9.0.0"
}
}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"@vue/eslint-config-typescript": "^4.0.0",
"chai": "^4.2.0",
"chai-as-promised": "^7.1.1",
"electron": "^8.0.0",
"electron": "^9.0.0",
"eslint-config-standard": "^14.0.0",
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-node": "^11.0.0",
Expand All @@ -70,7 +70,7 @@
"jest": "^24.8.0",
"lnk": "^1.1.0",
"rimraf": "^3.0.0",
"spectron": "^10.0.0",
"spectron": "^11.0.0",
"terminal-tasks": "^0.0.5",
"typescript": "^3.0.1",
"vue": "^2.5.20",
Expand Down
12 changes: 6 additions & 6 deletions prompts.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,8 @@ module.exports = [
name: 'electronBuilder.electronVersion',
type: 'list',
message: 'Choose Electron Version',
default: '^8.0.0',
default: '^9.0.0',
choices: [
{
name: '^6.0.0',
value: '^6.0.0',
short: '^6.0.0'
},
{
name: '^7.0.0',
value: '^7.0.0',
Expand All @@ -21,6 +16,11 @@ module.exports = [
name: '^8.0.0',
value: '^8.0.0',
short: '^8.0.0'
},
{
name: '^9.0.0',
value: '^9.0.0',
short: '^9.0.0'
}
],
when: () => {
Expand Down
Loading

0 comments on commit 261b78e

Please sign in to comment.