Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Leaked indirect Input #1884

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

benj2468
Copy link
Contributor

@benj2468 benj2468 commented Jan 7, 2025

Removes the leaked indirect inputs.systems. This created an ambiguous and indirect lockfile entry, this is resolved with this PR, which creates a clear original entry with fields similar to the locked entry.

Furthermore, not having it marked as an input is not inline with the examples of the nix-systems project found here.

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

Copy link
Contributor

@elikoga elikoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

This means that systems will not get resolved via https://github.com/NixOS/flake-registry but directly. And since we actually depend on it, a explicit reference in the inputs is good.

@Nebucatnetzer Nebucatnetzer merged commit 5c4de98 into nix-community:master Jan 7, 2025
194 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants