Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to effect for darwin ssh deploy #1059

Merged
merged 1 commit into from
Jan 23, 2025
Merged

switch to effect for darwin ssh deploy #1059

merged 1 commit into from
Jan 23, 2025

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 27, 2023

No description provided.

@zowoq zowoq force-pushed the effects-darwin branch 2 times, most recently from ec1bd80 to a04f58e Compare December 30, 2023 00:25
@zowoq zowoq force-pushed the effects-darwin branch 2 times, most recently from 87de2b1 to 8cde110 Compare January 14, 2024 23:42
@zowoq
Copy link
Contributor Author

zowoq commented Mar 31, 2024 •
edited
Loading

Now that we're in the process to switching to comin for nixos, adding support to comin for nix-darwin and having consistent deployments makes sense, closing.

Probably won't end up using it for darwin so we may as well switch to this.

@zowoq zowoq closed this Mar 31, 2024
@zowoq zowoq deleted the effects-darwin branch March 31, 2024 01:57
@zowoq zowoq mentioned this pull request Mar 31, 2024
Draft
@zowoq zowoq restored the effects-darwin branch July 21, 2024 03:50
@zowoq zowoq reopened this Jul 21, 2024
Mic92
Mic92 reviewed Jul 21, 2024
View reviewed changes
dev/effect.nix Outdated
userSetupScript = ''
writeSSHKey ssh-deployment
cat >>~/.ssh/known_hosts <<EOF
darwin02.nix-community.org ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAICJqwpMUEl1/iwrBakeDb1rlheXlE5mfDLICVz8w6yi6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably should test examples like that in my deployments as well.

@zowoq zowoq force-pushed the effects-darwin branch 8 times, most recently from 5d5b723 to 3e1bf56 Compare December 1, 2024 00:13
@zowoq zowoq force-pushed the effects-darwin branch 2 times, most recently from ef6f27a to b60c549 Compare January 21, 2025 04:29
zowoq
zowoq commented Jan 21, 2025
View reviewed changes
.github/workflows/darwin.yml Outdated
- name: Deploy
run: |
./inv deploy --hosts ${{ matrix.host }}
- name: Alert on failure
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't have this alert with effects but if it fails the buildbot status check will be red on master and darwin deploy failures were mostly a just problem on the m1s from hetzner, it has only failed a couple of times since we switched to the better m2/m4 machines.

Copy link
Contributor Author

@zowoq zowoq Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I've disabled this action, I'll remove it and the secrets later.

#1682

@zowoq zowoq force-pushed the effects-darwin branch 2 times, most recently from af70bc8 to af90655 Compare January 23, 2025 01:28
@zowoq zowoq marked this pull request as ready for review January 23, 2025 01:43
@zowoq zowoq added this pull request to the merge queue Jan 23, 2025
@zowoq zowoq removed this pull request from the merge queue due to a manual request Jan 23, 2025
@zowoq zowoq enabled auto-merge January 23, 2025 01:47
@zowoq zowoq added this pull request to the merge queue Jan 23, 2025
Merged via the queue into master with commit 3464ec2 Jan 23, 2025
3 checks passed
@zowoq zowoq deleted the effects-darwin branch January 23, 2025 01:49
@zowoq zowoq mentioned this pull request Jan 23, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
secrets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zowoq @Mic92