feat(yazi): Add assertion to prevent conflicting keybinds #6343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, you can accidentally define conflicting keybinds and you will not get any warning.
This PR adds an assertion which checks if there are any two keybinds A and B where the
on
value (sequence of keypresses) of A starts with theon
value of B.This is not yet finished but I will pick it up when I have time again.
Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Maintainer CC
@XYenon @eljamm
btw would you be interested in me becoming a maintainer of the yazi module?
This is my second contribution to this module and I am also maintaining the
nix-yazi-plugins
repo (not afiliated with yazi or home-manager but relevant IMO), so I plan to keep contributing here in the forseeable future.