Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdg-portal: add note about useUserPackages and pathsToLink #5184

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

Misterio77
Copy link
Contributor

Description

Addresses #5158 (comment)

When using the NixOS module with useUserPackages = true, share/xdg-desktop-portal from home-manager-path won't get linked into the profile, similarly to bash completions and friends.

This PR adds a note on the fix, that is simply adding it to pathsToLink on the system configuration.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@Misterio77
Copy link
Contributor Author

Misterio77 commented Apr 8, 2024

Hey @rycee, sorry for the ping. Could you take a look at this one? Thanks!

@colemickens
Copy link
Member

+1, please @rycee this needs to be merged.

@rycee rycee force-pushed the xdg-portal-path-note branch from 05990ea to 27963b6 Compare April 27, 2024 07:37
Specifically, add note about useUserPackages and pathsToLink. As
suggested in
<nix-community#5158 (comment)>.
@rycee rycee force-pushed the xdg-portal-path-note branch from 27963b6 to c1609d5 Compare April 27, 2024 07:40
@rycee rycee merged commit c1609d5 into nix-community:master Apr 27, 2024
3 checks passed
@rycee
Copy link
Member

rycee commented Apr 27, 2024

Thanks and apologies for the delay! Merged to master now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants