Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to controllable #224

Open
wants to merge 51 commits into
base: develop
Choose a base branch
from
Open

Migrate to controllable #224

wants to merge 51 commits into from

Conversation

nivisi
Copy link
Owner

@nivisi nivisi commented Nov 25, 2022

Resolves #213

Quite a big PR

 (╯⪩o⪨）╯︵ ┻━┻

@nivisi nivisi force-pushed the migrate-to-controllable branch from 1b83533 to 43e6bc0 Compare November 25, 2022 19:41
@nivisi nivisi mentioned this pull request Nov 25, 2022
Open
@nivisi
Copy link
Owner Author

nivisi commented Nov 25, 2022 •
edited
Loading

Found bugs:

  • Toggling timeline leads to disabling it at some point
  • Home app selection says 'launch app'
  • Corner apps don't vibrate on tap

UI/UX:

  • Make distance between items in the picker bigger

@nivisi
Copy link
Owner Author

nivisi commented Nov 26, 2022 •
edited
Loading

Findings:

  • Home app selection has to have:
    • Autofocus
    • Title "Select X app"
    • Dismiss on selection

@nivisi
Copy link
Owner Author

nivisi commented Dec 8, 2022 •
edited
Loading

  • Home search doesn't work

@nivisi
Copy link
Owner Author

nivisi commented Dec 8, 2022 •
edited
Loading

Findings:

  • Autolaunch on first match doesn't work
  • Back button doesn't close the corner app picker

@nivisi
Copy link
Owner Author

nivisi commented Dec 30, 2022 •
edited
Loading

  • Picker needs always scrollable physics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to controllable
1 participant
@nivisi