Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Reduce auto recommending MCRIBS after 3 (chronological) months #438

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Jan 24, 2025

After comparisons across surface methods (mcribs/infantfs/fs_reconall) on BCP subjects (image below), and revisiting the MCRIBS paper, this PR caps using mcribs as the "recommended" surface reconstruction method to the first 3 months (chronological).

image

This only changes a recommendation - users are still available to run any of the surface reconstruction methods for participants of any age (--surface-recon-method <method>).

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.45%. Comparing base (fef5aa8) to head (4e0cf4b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
nibabies/workflows/base.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   56.45%   56.45%           
=======================================
  Files          70       70           
  Lines        6719     6719           
  Branches      828      828           
=======================================
  Hits         3793     3793           
  Misses       2717     2717           
  Partials      209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mgxd mgxd merged commit 30b0d57 into nipreps:master Jan 24, 2025
15 of 16 checks passed
@mgxd mgxd deleted the fix/surface-recon-auto branch January 24, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant