Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#83] Create UI test example for Detail screen #95

Merged
merged 9 commits into from
Feb 24, 2023
Merged

[#83] Create UI test example for Detail screen #95

merged 9 commits into from
Feb 24, 2023

Conversation

kaungkhantsoe
Copy link
Contributor

@kaungkhantsoe kaungkhantsoe commented Feb 6, 2023 •
edited
Loading

What happened 👀

Add Detail screen UI test

Insight 📝

  • With current implementation, we cannot mock the error from repository. That is why, in order to test loading, we need to assert the loading node without initializing ViewModel.

  • Above method won't work if we want to assert pull to refresh

Proof Of Work 📹

My.Movie.mp4

@kaungkhantsoe kaungkhantsoe marked this pull request as draft February 6, 2023 10:45
@kaungkhantsoe kaungkhantsoe changed the title [83] add UI test for detail screen [#83] Create UI test example for Detail screen Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited
Loading

12 Warnings
⚠️ Please use more than one word.
8ae5de7
⚠️ Please separate subject from body with newline.
8ae5de7
⚠️ Please remove period from end of commit subject line.
821ed83
⚠️ Please remove period from end of commit subject line.
b1aa460
⚠️ /home/runner/.gradle/caches/transforms-3/fc63d10724654858d2ee5b467b86b5a7/transformed/jetified-dagger-lint-aar-2.43.2/jars/lint.jar#L0 - Lint found an issue registry (dagger.lint.DaggerIssueRegistry) which requires a newer API level. That means that the custom lint checks are intended for a newer lint version; please upgrade.
⚠️ app/src/main/AndroidManifest.xml#L10 - On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup, or just set android:fullBackupOnly=true. More info: https://developer.android.com/guide/topics/data/autobackup
⚠️ app/src/main/AndroidManifest.xml#L13 - Attribute networkSecurityConfig is only used in API level 24 and higher (current min is 23)
⚠️ app/src/main/java/co/nimblehq/compose/crypto/ui/common/Toaster.kt#L16 - Toast created but not shown: did you forget to call show() ?
⚠️ app/src/main/res/drawable/ic_back.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23)
⚠️ app/src/main/res/drawable/ic_fire_opal_arrow_down.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23)
⚠️ app/src/main/res/drawable/ic_guppie_green_arrow_up.xml#L8 - Attribute fillType is only used in API level 24 and higher (current min is 23)
⚠️ app/src/main/res/navigation/nav_graph_main.xml#L2 - The resource R.navigation.nav_graph_main appears to be unused

CoroutineTemplate Jacoco report:

Generated by 🚫 Danger

@kaungkhantsoe kaungkhantsoe self-assigned this Feb 6, 2023
@kaungkhantsoe kaungkhantsoe marked this pull request as ready for review February 7, 2023 05:08
doannimble
doannimble reviewed Feb 9, 2023
View reviewed changes
Copy link

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/detail/DetailScreenTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/detail/DetailScreenTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/detail/DetailScreenTest.kt Outdated Show resolved Hide resolved
doannimble
doannimble approved these changes Feb 16, 2023
View reviewed changes
Copy link

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 💯

luongvo
luongvo reviewed Feb 17, 2023
View reviewed changes
Copy link
Member

@luongvo luongvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/detail/DetailScreenUiTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/detail/DetailScreenUiTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/detail/DetailScreenUiTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/detail/DetailScreenUiTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/detail/DetailScreenUiTest.kt Outdated Show resolved Hide resolved
hoangnguyen92dn
hoangnguyen92dn approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@hoangnguyen92dn hoangnguyen92dn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM 🚀

app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/detail/DetailScreenUiTest.kt Outdated Show resolved Hide resolved
@kaungkhantsoe kaungkhantsoe force-pushed the chore/83-add-ui-test-for-detail-screen branch from 9052846 to bae9ef7 Compare February 20, 2023 07:03
Base automatically changed from chore/74-create-home-screen-ui-test to develop February 20, 2023 08:51
@Wadeewee
Copy link
Contributor

FYI: I will update some tests for UnitTest to make it match with the UI Test in this PR 🚀

@kaungkhantsoe
[#83] Minor refactors from PR.
821ed83
@kaungkhantsoe
[#83] Remove redundant space
f3ce8b5
@kaungkhantsoe
[#83]
8ae5de7 
- Use coinUiModel instead of coinDetail
- Move HomeScreenUITest to home folder
- Rename DetailScreenUiTest to DetailScreenUITest
@kaungkhantsoe kaungkhantsoe force-pushed the chore/83-add-ui-test-for-detail-screen branch from dfc863d to 8ae5de7 Compare February 21, 2023 09:00
@kaungkhantsoe kaungkhantsoe merged commit 6e752c4 into develop Feb 24, 2023
@kaungkhantsoe kaungkhantsoe deleted the chore/83-add-ui-test-for-detail-screen branch February 24, 2023 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangnguyen92dn hoangnguyen92dn hoangnguyen92dn approved these changes

@luongvo luongvo luongvo approved these changes

@Wadeewee Wadeewee Wadeewee approved these changes

@doannimble doannimble doannimble approved these changes

Assignees

@kaungkhantsoe kaungkhantsoe

Labels
type : chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kaungkhantsoe @Wadeewee @hoangnguyen92dn @luongvo @doannimble