-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#74] Create HomeScreenUITest #86
Conversation
CoroutineTemplate Jacoco report:Generated by 🚫 Danger |
a5d3ee7
to
2792b49
Compare
2792b49
to
5d95fc7
Compare
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Show resolved
Hide resolved
Another concern is we need to omit the last two test cases from @Test
fun `When pulled to refresh and load MyCoins successfully, it render the UI properly`() @Test
fun `When pulled to refresh and load TrendingCoins successfully, it render the UI properly`() It seems like the onRoot().performTouchInput { swipeDown() } That's why we can't test these test cases. Please let me know if you have any insight into this, the problem is similar to my above concern, I guess 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/BaseScreenTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
@hoangnguyen92dn @kaungkhantsoe @luongvo @doannimble, Regarding this issue, I think we can investigate it later as It works fine when creating the |
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/co/nimblehq/compose/crypto/ui/screens/home/HomeViewModel.kt
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest lgtm; please check my reply on this issue too #86 (comment)
app/src/androidTest/java/co/nimblehq/compose/crypto/ui/screen/HomeScreenUITest.kt
Outdated
Show resolved
Hide resolved
app/src/test/java/co/nimblehq/compose/crypto/ui/screens/home/HomeScreenTest.kt
Outdated
Show resolved
Hide resolved
0f12293
to
b905c32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Wadeewee much better 👏
#74
What happened 👀
Create HomeScreen as UI Test.
Insight 📝
testInstrumentationRunner
indefaultConfig
UI Test
:androidx.compose.ui:ui-test-junit4
io.mockk:mockk-android
io.mockk:mockk-agent-android
io.kotest:kotest-assertions-core
mockk-agent-android
, we need to upgrade the version ofMocck
to1.12.3
if not, we will get this error:packagingOptions
and set thejniLibs
touseLegacyPackaging
=true
to fix this error:CoroutineTestRule
.BaseScreenTest
.MockUtil
.Proof Of Work 📹
Screen.Recording.2566-01-30.at.15.17.11.mov