Skip to content

Commit

Permalink
Fixes dash in ternary-tree. Refs #1683
Browse files Browse the repository at this point in the history
  • Loading branch information
@dom96
dom96 authored Nov 3, 2020
1 parent 3597f40 commit 1f0103a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14553,7 +14553,7 @@
"web": "https://github.com/Cirru/parser.nim"
},
{
"name": "ternary-tree",
"name": "ternary_tree",
"url": "https://github.com/Cirru/ternary-tree",
"method": "git",
"tags": [
Expand Down

6 comments on commit 1f0103a

@narimiran
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix his other package just above: cirru-parser.

@tiye
Copy link
Contributor

@tiye tiye commented on 1f0103a Nov 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er... wish myself got pinged...

so are you going to correct all the names with - inside?

cirru-parser
io-egl
io-gles
io-isense
io-myo
io-oculus
io-serialport
io-sixense
io-spacenav
io-usb
jade-nim
nim-ao
nim-geocoding
nim-glfw
nim-libclang
nim-libgd
nim-locale
nim-nmap
nim-ogg
nim-portaudio
nim-sndfile
nim-vorbis
nimrod-glfw
woocommerce-api-nim
XPLM-Nim

probably I'm the only user ofcirru-parser. if you are going to rename, just do it. I would migrate my configs after you finished.

@dom96
Copy link
Contributor Author

@dom96 dom96 commented on 1f0103a Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most (if not all) of those packages are old. Very old. And yes, they should be removed.

@dom96
Copy link
Contributor Author

@dom96 dom96 commented on 1f0103a Nov 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed cirru-parser. @narimiran please feel free to make these changes yourself in the future btw, it'll save us both time :)

@tiye
Copy link
Contributor

@tiye tiye commented on 1f0103a Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe updating the rules in https://github.com/nim-lang/packages/blob/master/validate_json.js#L2 so that future PRs get checked?

@dom96
Copy link
Contributor Author

@dom96 dom96 commented on 1f0103a Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1698

Please sign in to comment.