nimony: subscripts with invocations as special case #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined here, would also have a special case for generic routines but there is nothing to call for them yet. Anything that is not an invocation is treated as an overloaded call to
[], which needs to have magic overloads.Note for the future: nim-lang/Nim#9997, standalone instantiations of symchoices shouldn't generate a symchoice of the instantiated symbols as Nim currently does, instead it should probably be treated as an "instantiation choice" either remaining as a bracket over a symchoice or its own node kind that can later be type-fit to a specific instantiation