Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add minutes december 2024 #45

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Remi-Gau
Copy link
Contributor

No description provided.

@Remi-Gau Remi-Gau requested review from bthirion and emdupre December 13, 2024 08:55
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

- [#4879](https://github.com/nilearn/nilearn/issues/4879) - `Make some surface 'utility functions' public`
- move them under nilearn.surface but as private
- naming should be closer to nilearn.image
- and revisit later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- and revisit later
- and revisit later whether to have under nilearn.surface or nilearn.image

IIRC ?

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small clarification but this LGTM, thank you @Remi-Gau !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants