Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy the value from slice to avoid the original value being modified #572

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

ktong
Copy link
Collaborator

@ktong ktong commented Nov 21, 2024

It has code to deep copy map but not slice. This PR also copies value for slice

@ktong ktong added the Skip-Changelog This doesn't require a change log label Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.8%. Comparing base (411ab81) to head (9b56adf).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #572   +/-   ##
=====================================
  Coverage   82.7%   82.8%           
=====================================
  Files         62      62           
  Lines       3310    3319    +9     
=====================================
+ Hits        2740    2749    +9     
  Misses       485     485           
  Partials      85      85           
Files with missing lines Coverage Δ
internal/convert/converter.go 99.3% <100.0%> (+<0.1%) ⬆️
internal/maps/transform.go 100.0% <100.0%> (ø)
---- 🚨 Try these New Features:

@ktong ktong merged commit 1f54b69 into main Nov 21, 2024
67 checks passed
@ktong ktong deleted the kt_slice branch November 21, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog This doesn't require a change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant