Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor #120

Merged
merged 1 commit into from
Feb 11, 2024
Merged

refactor #120

merged 1 commit into from
Feb 11, 2024

Conversation

ktong
Copy link
Collaborator

@ktong ktong commented Feb 10, 2024

No description provided.

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (23d42a3) 79.9% compared to head (a26673f) 80.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #120     +/-   ##
=======================================
+ Coverage   79.9%   80.0%   +0.1%     
=======================================
  Files         22      22             
  Lines        774     773      -1     
=======================================
  Hits         619     619             
  Misses       141     141             
+ Partials      14      13      -1     
Files Coverage Δ
provider/flag/option.go 69.2% <ø> (ø)
provider/pflag/option.go 69.2% <ø> (ø)
provider/appconfig/appconfig.go 92.0% <80.0%> (+0.9%) ⬆️

@ktong ktong changed the title add provider/appconfiguration add provider/azappconfig Feb 10, 2024
@ktong ktong force-pushed the kt_azure branch 10 times, most recently from 66099eb to e0ca62e Compare February 10, 2024 23:20
@ktong ktong changed the title add provider/azappconfig do not use Tomic Feb 10, 2024
@ktong ktong changed the title do not use Tomic do not use atomic Feb 10, 2024
@ktong ktong added the Skip-Changelog This doesn't require a change log label Feb 10, 2024
@ktong ktong marked this pull request as ready for review February 10, 2024 23:24
@ktong ktong changed the title do not use atomic refactor Feb 11, 2024
@ktong ktong merged commit b17401e into main Feb 11, 2024
29 checks passed
@ktong ktong deleted the kt_azure branch February 11, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog This doesn't require a change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant