do not panic (#184)

return error on Load instead

CHANGELOG.md

@@ -10,6 +10,7 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 ### Removed
 - Remove konf.Default() to disallow loading configuration into the default Config (#180).
 - Remove ExplainOption from Config.Explain for always blurring sensitive information (#180).
+- Remove LoadOption from Config.Load (#184).
 
 ## [0.6.3] - 2024-02-23
 

config.go

@@ -4,7 +4,7 @@
 package konf
 
 import (
-	"context"
+	"errors"
 	"fmt"
 	"log/slog"
 	"slices"
@@ -79,33 +79,20 @@ func New(opts ...Option) Config {
 	return Config(*option)
 }
 
+var errNilLoader = errors.New("cannot load config from nil loader")
+
 // Load loads configuration from the given loader.
 // Each loader takes precedence over the loaders before it.
 //
 // This method can be called multiple times but it is not concurrency-safe.
-func (c Config) Load(loader Loader, opts ...LoadOption) error {
+func (c Config) Load(loader Loader) error {
 	if loader == nil {
-		c.logger.Warn("cannot load config from nil loader")
-
-		return nil
-	}
-
-	loadOption := &loadOptions{}
-	for _, opt := range opts {
-		opt(loadOption)
+		return errNilLoader
 	}
 
 	values, err := loader.Load()
 	if err != nil {
-		if !loadOption.continueOnError {
-			return fmt.Errorf("load configuration: %w", err)
-		}
-		c.logger.LogAttrs(
-			context.Background(), slog.LevelWarn,
-			"failed to load configuration",
-			slog.Any("loader", loader),
-			slog.Any("error", err),
-		)
+		return fmt.Errorf("load configuration: %w", err)
 	}
 	maps.Merge(c.values.values, values)
 

config_test.go

@@ -20,21 +20,16 @@ func TestConfig_Load(t *testing.T) {
 	testcases := []struct {
 		description string
 		loader      konf.Loader
-		opts        []konf.LoadOption
 		err         string
 	}{
 		{
 			description: "error",
 			loader:      &errorLoader{},
 			err:         "load configuration: load error",
 		},
-		{
-			description: "continue on error",
-			loader:      &errorLoader{},
-			opts:        []konf.LoadOption{konf.ContinueOnError()},
-		},
 		{
 			description: "nil loader",
+			err:         "cannot load config from nil loader",
 		},
 	}
 
@@ -45,7 +40,7 @@ func TestConfig_Load(t *testing.T) {
 			t.Parallel()
 
 			config := konf.New()
-			err := config.Load(testcase.loader, testcase.opts...)
+			err := config.Load(testcase.loader)
 			if testcase.err == "" {
 				assert.NoError(t, err)
 			} else {

internal/credential/credentials.go

@@ -6,6 +6,7 @@ package credential
 import (
 	"fmt"
 	"regexp"
+	"unsafe"
 )
 
 func Blur(name string, value any) string {
@@ -18,7 +19,7 @@ func Blur(name string, value any) string {
 	case string:
 		formatted = v
 	case []byte:
-		formatted = string(v)
+		formatted = unsafe.String(unsafe.SliceData(v), len(v))
 	default:
 		formatted = fmt.Sprint(value)
 	}

option.go

@@ -51,18 +51,3 @@ type (
 	Option  func(*options)
 	options Config
 )
-
-// ContinueOnError allows watcher continues watching configuration even Config.Load fails to load the loader.
-func ContinueOnError() LoadOption {
-	return func(options *loadOptions) {
-		options.continueOnError = true
-	}
-}
-
-type (
-	// LoadOption configures Config.Load with specific options.
-	LoadOption  func(*loadOptions)
-	loadOptions struct {
-		continueOnError bool
-	}
-)

provider/appconfig/appconfig.go

@@ -37,16 +37,6 @@ type AppConfig struct {
 
 // New creates an AppConfig with the given application, environment, profile and Option(s).
 func New(application, environment, profile string, opts ...Option) AppConfig {
-	if application == "" {
-		panic("cannot create AppConfig with empty application")
-	}
-	if environment == "" {
-		panic("cannot create AppConfig with empty environment")
-	}
-	if profile == "" {
-		panic("cannot create AppConfig with empty profile")
-	}
-
 	option := &options{
 		client: &clientProxy{
 			application: application,

provider/appconfig/appconfig_test.go

@@ -23,53 +23,6 @@ import (
 	"github.com/nil-go/konf/provider/appconfig/internal/assert"
 )
 
-func TestAppConfig_New_panic(t *testing.T) {
-	t.Parallel()
-
-	testcases := []struct {
-		description string
-		call        func()
-		err         string
-	}{
-		{
-			description: "application",
-			call: func() {
-				appconfig.New("", "env", "profile")
-			},
-			err: "cannot create AppConfig with empty application",
-		},
-		{
-			description: "environment",
-			call: func() {
-				appconfig.New("app", "", "profile")
-			},
-			err: "cannot create AppConfig with empty environment",
-		},
-		{
-			description: "profile",
-			call: func() {
-				appconfig.New("app", "env", "")
-			},
-			err: "cannot create AppConfig with empty profile",
-		},
-	}
-
-	for _, testcase := range testcases {
-		testcase := testcase
-
-		t.Run(testcase.description, func(t *testing.T) {
-			t.Parallel()
-
-			defer func() {
-				assert.Equal(t, testcase.err, recover().(string))
-			}()
-
-			testcase.call()
-			t.Fail()
-		})
-	}
-}
-
 func TestAppConfig_Load(t *testing.T) {
 	t.Parallel()
 

provider/azappconfig/appconfig.go

@@ -36,10 +36,6 @@ type AppConfig struct {
 
 // New creates an AppConfig with the given endpoint and Option(s).
 func New(endpoint string, opts ...Option) AppConfig {
-	if endpoint == "" {
-		panic("cannot create Azure AppConfig with empty endpoint")
-	}
-
 	option := &options{
 		client: &clientProxy{
 			// Place holder for the default credential.

provider/azappconfig/appconfig_test.go

@@ -20,15 +20,13 @@ import (
 	"github.com/nil-go/konf/provider/azappconfig/internal/assert"
 )
 
-func TestFile_New_panic(t *testing.T) {
+func TestAppConfig(t *testing.T) {
 	t.Parallel()
 
-	defer func() {
-		assert.Equal(t, "cannot create Azure AppConfig with empty endpoint", recover().(string))
-	}()
-
-	azappconfig.New("")
-	t.Fail()
+	loader := azappconfig.New("")
+	values, err := loader.Load()
+	assert.Equal(t, nil, values)
+	assert.EqualError(t, err, "next page of list settings: no Host in request URL")
 }
 
 func TestAppConfig_Load(t *testing.T) {

provider/file/file.go

@@ -30,10 +30,6 @@ type File struct {
 //
 // It panics if the path is empty.
 func New(path string, opts ...Option) File {
-	if path == "" {
-		panic("cannot create File with empty path")
-	}
-
 	option := &options{
 		path: path,
 	}

provider/file/file_test.go

@@ -11,17 +11,6 @@ import (
 	"github.com/nil-go/konf/provider/file/internal/assert"
 )
 
-func TestFile_New_panic(t *testing.T) {
-	t.Parallel()
-
-	defer func() {
-		assert.Equal(t, "cannot create File with empty path", recover().(string))
-	}()
-
-	file.New("")
-	t.Fail()
-}
-
 func TestFile_Load(t *testing.T) {
 	t.Parallel()
 
@@ -32,6 +21,10 @@ func TestFile_Load(t *testing.T) {
 		expected    map[string]any
 		err         string
 	}{
+		{
+			description: "empty path",
+			err:         "read file: open : no such file or directory",
+		},
 		{
 			description: "file",
 			path:        "testdata/config.json",

provider/flag/flag.go

@@ -42,10 +42,6 @@ type konf interface {
 //
 // It panics if the konf is nil.
 func New(konf konf, opts ...Option) Flag {
-	if konf == nil {
-		panic("cannot create Flag with nil konf")
-	}
-
 	option := &options{
 		konf: konf,
 	}

provider/flag/flag_test.go

@@ -13,35 +13,36 @@ import (
 	kflag "github.com/nil-go/konf/provider/flag"
 )
 
-func TestFlag_New_panic(t *testing.T) {
-	t.Parallel()
-
-	defer func() {
-		assert.Equal(t, "cannot create Flag with nil konf", recover().(string))
-	}()
-
-	kflag.New(nil)
-	t.Fail()
-}
-
 func TestFlag_Load(t *testing.T) {
 	t.Parallel()
 
 	testcases := []struct {
 		description string
-		exists      bool
+		konf        konf
 		opts        []kflag.Option
 		expected    map[string]any
 	}{
+		{
+			description: "nil konf",
+			opts:        []kflag.Option{kflag.WithPrefix("p.")},
+			expected: map[string]any{
+				"p": map[string]any{
+					"k": "v",
+					"d": ".",
+				},
+			},
+		},
 		{
 			description: "with flag set",
+			konf:        konf{exists: false},
 			opts:        []kflag.Option{kflag.WithFlagSet(set)},
 			expected: map[string]any{
 				"k": "v",
 			},
 		},
 		{
 			description: "with delimiter",
+			konf:        konf{exists: false},
 			opts: []kflag.Option{
 				kflag.WithPrefix("p_"),
 				kflag.WithNameSplitter(func(s string) []string { return strings.Split(s, "_") }),
@@ -54,6 +55,7 @@ func TestFlag_Load(t *testing.T) {
 		},
 		{
 			description: "with nil splitter",
+			konf:        konf{exists: false},
 			opts: []kflag.Option{
 				kflag.WithPrefix("p_"),
 				kflag.WithNameSplitter(func(string) []string { return nil }),
@@ -62,6 +64,7 @@ func TestFlag_Load(t *testing.T) {
 		},
 		{
 			description: "with empty splitter",
+			konf:        konf{exists: false},
 			opts: []kflag.Option{
 				kflag.WithPrefix("p_"),
 				kflag.WithNameSplitter(func(string) []string { return []string{""} }),
@@ -70,6 +73,7 @@ func TestFlag_Load(t *testing.T) {
 		},
 		{
 			description: "with prefix",
+			konf:        konf{exists: false},
 			opts:        []kflag.Option{kflag.WithPrefix("p.")},
 			expected: map[string]any{
 				"p": map[string]any{
@@ -80,7 +84,7 @@ func TestFlag_Load(t *testing.T) {
 		},
 		{
 			description: "with exists",
-			exists:      true,
+			konf:        konf{exists: true},
 			opts:        []kflag.Option{kflag.WithPrefix("p.")},
 			expected: map[string]any{
 				"p": map[string]any{
@@ -97,7 +101,7 @@ func TestFlag_Load(t *testing.T) {
 		t.Run(testcase.description, func(t *testing.T) {
 			t.Parallel()
 
-			values, err := kflag.New(konf{exists: testcase.exists}, testcase.opts...).Load()
+			values, err := kflag.New(testcase.konf, testcase.opts...).Load()
 			assert.NoError(t, err)
 			assert.Equal(t, testcase.expected, values)
 		})

provider/fs/config.json

@@ -0,0 +1 @@
+{"p":{"k":"v"}}