Fix Unsubscribe & Add parameter for clientlist & Added GetClient* Methods #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix some async methodnames; Remove await from ssh connection
lgund
changed the title
Splamy
reviewed
Oct 8, 2020
| @@ -26,9 +27,10 @@ The TeamSpeak 3 Query API is documented [here](http://media.teamspeak.com/ts3_li | |||
| This library has an online documentation which was created using [sharpDox](http://sharpdox.de). You can find the documentation on the [GitHub Page of this repository](https://nikeee.github.io/TeamSpeak3QueryAPI). | |||
|
|
|||
| ## Compatibility | |||
| This library requires .NET Standard `1.3`. You can look at [this table](https://docs.microsoft.com/en-us/dotnet/standard/net-standard#net-implementation-support) to see whether your platform is supported. If you find something that is missing (espacially in the `TeamSpeakClient` class), just submit a PR or an issue! | |||
| This library requires .NET Core `3.0`. You can look at [this table](https://docs.microsoft.com/en-us/dotnet/standard/net-standard#net-implementation-support) to see whether your platform is supported. If you find something that is missing (espacially in the `TeamSpeakClient` class), just submit a PR or an issue! | |||
There was a problem hiding this comment.
The library still only requires .NET Standard 1.3
There was a problem hiding this comment.
This PR contains changes that were merged to the ssh branch. Only the latest commits are relevant.
|
Before we can review this PR: |
There are 2 commits which are fixing the unsubscribe bug. First the equal method and the second is to remove the listed function from the callback list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsubscribe fix
There was still the problem that the callback wasn't removed. So I add that the saved callback will be revmoved from the _callbacks list.
Clientlist parameter
Clientlist has the parameter -ip. It´s not in the ts3 manuel but it works. I used this parameter on my project so I added this into this fork too.
GetClientMethods
I´ve added the methods from the other pr #53 . I´ve just changed the names and parameters to the current "style"