build: wixv4 msi build (fixes #1) #12
Conversation
This commit adds a WiX v4 MSI build to the project. The build is run from the msi/build.ps1 script. A GitHub workflow is added to run the build and upload the MSI as an artifact.
|
I've only briefly looked at this, I'll take a deeper look in the next days. I'm wondering if it makes sense to have CI build an msi for every commit on master and for every PR? Personally I don't think so, an msi package only needs to be built for releases which are created manually. |
It's not implemented yet, but it would also be triggered by a release action and then uploaded to the release. The reason for doing it "a lot" is coverage. It's nice to see it break on the PR rather than whenever the release is made. |
| <Project Sdk="WixToolset.Sdk/4.0.4"> | ||
| <PropertyGroup> | ||
| <DefineConstants> ApplicationFiles=$(PORTABLE_PATH)/ | ||
| </DefineConstants> | ||
| <OutputName>$(MSI_NAME)</OutputName> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="WixToolset.Heat" Version="4.0.4" /> | ||
| <PackageReference Include="WixToolset.UI.wixext" Version="4.0.4" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Update to 4.0.6 or 5.0.2
This commit adds a WiX v4 MSI build to the project. The build is run from the msi/build.ps1 script. A GitHub workflow is added to run the build and upload the MSI as an artifact.
MSI artifact here: https://github.com/JPHutchins/wsl-usb-manager/actions/runs/11768450149
Closes #1