Stream browser awg display #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stream-browser-awg-display
- Added FucntionGeneratorState to cache generator configuration - Added awg state update logic in instrument thread - Updated FunctionGeneratorDialog to track changes in awg state - First step to awg rendering
… stream-browser-awg-display
Refactored renderCombo methods to pass selected value as an input/ouput parameter. Added wave shapes possible values to awg state.
Added channel color to shape combo.
Fixed UI update to support slow instruments on FunctionGenerator rendering First step to wave shape preview.
… stream-browser-awg-display
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
This one is for rendering FunctionGenerator in StreamBrowserDialog:
I created previews for all available waveform shapes, but as I have absolutely no skills in graphic design, some of them will probably need some rework !...
As no caching is done on current FunctionGenerator drivers I implemented it in Session/InstrumentThread like you did for PSUs.
Best,
Frederic.