Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated unit test files with logr.Discard #3082

Closed
wants to merge 6 commits into from
Closed

updated unit test files with logr.Discard #3082

wants to merge 6 commits into from

Conversation

KR411-prog
Copy link

Proposed changes

replace unit test loggers with logr.Discard()

Testing: Ran make unit-test

Closes #3041

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [* ] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • [ *] I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • [* ] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@KR411-prog KR411-prog requested a review from a team as a code owner February 2, 2025 21:25
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 2, 2025 •
edited
Loading

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:

I have hereby read the F5 CLA and agree to its terms

2 out of 3 committers have signed the CLA.
✅ (salonichf5)[https://github.com/salonichf5]
✅ (bjee19)[https://github.com/bjee19]
❌ @radha Ramadoss
Radha Ramadoss seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@KR411-prog
Copy link
Author

I have hereby read the F5 CLA and agree to its terms

salonichf5 and others added 5 commits February 2, 2025 16:57
@salonichf5 @KR411-prog
Listener Isolation for hostnames occupied by other listeners (nginx#3067
2e9ff47 
)

Listener Isolation for hostnames occupied by other listeners

Problem: Users want to be able to isolate listeners for routes.

Solution: Adds functionality to filter out listener hostnames from the accepted hostnames of a route which belong to another listener.
@bjee19 @KR411-prog
Allow configuration of NGINX Plus API access (nginx#3066)
5b1b7c3 
Allow configuration of NGINX Plus API access.

Problem: We want the ability to configure access to the NGINX Plus dashboard.

Solution: Add a field AllowedAddresses in the NginxProxy API to allow the user to configure access to the NGINX Plus dashboard.

Testing: Unit tests. Manually configured an NginxProxy resource, set up a Kind cluster with a Nodeport following our Get started guide, and confirmed that I could access the dashboard without needing to port-forward. Verified nginx plus template code is present when running on nginx plus and not present when running on nginx oss.
@renovate @KR411-prog
Update pre-commit hook gitleaks/gitleaks to v8.23.3 (nginx#3077)
72992ae 
| datasource  | package           | from    | to      |
| ----------- | ----------------- | ------- | ------- |
| github-tags | gitleaks/gitleaks | v8.23.2 | v8.23.3 |

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @KR411-prog
Update github/codeql-action action to v3.28.8 (nginx#3075)
3e2744a 
| datasource  | package              | from    | to      |
| ----------- | -------------------- | ------- | ------- |
| github-tags | github/codeql-action | v3.28.6 | v3.28.8 |

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @KR411-prog
Update module github.com/spf13/pflag to v1.0.6 (nginx#3076)
88b3a6b 
* Update module github.com/spf13/pflag to v1.0.6

| datasource | package                | from   | to     |
| ---------- | ---------------------- | ------ | ------ |
| go         | github.com/spf13/pflag | v1.0.5 | v1.0.6 |


Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Update files for renovate

---------

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@KR411-prog KR411-prog requested a review from a team as a code owner February 2, 2025 22:01
@github-actions github-actions bot added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file helm-chart Relates to helm chart labels Feb 2, 2025
@KR411-prog KR411-prog closed this Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation helm-chart Relates to helm chart
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace test logger with logr.Discard()
3 participants
@KR411-prog @salonichf5 @bjee19