-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate NX #98
base: master
Are you sure you want to change the base?
Migrate NX #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ng-package.json is missing in validators package
"prefix": "ngx-validate", | ||
"targets": { | ||
"test": { | ||
"executor": "@nrwl/jest:jest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test executor different from other packages' test executor.
"@angular/common": ">=5.0.0", | ||
"@angular/core": ">=5.0.0", | ||
"@angular/forms": ">=5.0.0", | ||
"rxjs": ">=6.0.0 || ^5.6.0-forward-compat.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depended rxjs version is 7.5.0
"@angular/common": ">=5.0.0", | ||
"@angular/core": ">=5.0.0", | ||
"@angular/forms": ">=5.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depended angular version is 15
ng add @nrwl/angular --preserve-angular-cli-layout
)todo:
[ ] Add build target to validators
[ ] Add ng-packages