Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: try older w3up client" #2549

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Apr 2, 2024

Reverts #2548

Why?

  • that downgrade of w3up-client didn't fix everything
  • @hannahhoward mentioned that in local testing, she thinks that the newer version doesn't use extra memory when configured with a null pieceHasher, which is what we're doing
  • I can't think of a good reason to be on old version vs latest version

Copy link

Deploying nft-storage with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8987fe9
Status: ✅  Deploy successful!
Preview URL: https://bde4af7f.nft-storage-1at.pages.dev
Branch Preview URL: https://revert-2548-fix-try-older-cl.nft-storage-1at.pages.dev

View logs

@gobengo gobengo marked this pull request as ready for review April 2, 2024 18:21
Copy link
Contributor

@hannahhoward hannahhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@travis travis merged commit b31847b into main Apr 2, 2024
23 checks passed
@travis travis deleted the revert-2548-fix/try-older-client branch April 2, 2024 21:25
travis pushed a commit that referenced this pull request Apr 3, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.5.0](api-v4.4.3...api-v4.5.0)
(2024-04-02)


### Features

* POST /uploads can write uploads to w3up for web3 serving and
dagcargoless filecoin deal-making
([#2522](#2522))
([0c77cb3](0c77cb3))
* uploadCarWithStat avoids copying stat.carBytes via Blob construction
([#2543](#2543))
([bcb67a3](bcb67a3))


### Bug Fixes

* add a fake piece hasher to try to fix staging upload issues
([#2542](#2542))
([542983c](542983c))
* avoid car repack
([#2551](#2551))
([b0d622e](b0d622e))
* avoid car repack
([#2552](#2552))
([b4ff571](b4ff571))
* change to post method
([#2547](#2547))
([65e20fb](65e20fb))
* enable `url_standard` compatbility flag
([#2540](#2540))
([bdde10a](bdde10a))
* enable the `url_standard` compatibility flag
([#2537](#2537))
([e822bab](e822bab))
* enabled nodejs compat
([#2545](#2545))
([654cde7](654cde7))
* log out proof
([225cf28](225cf28))
* log proof for debugging
([#2535](#2535))
([0ecace3](0ecace3))
* more logging
([#2536](#2536))
([11ae646](11ae646))
* remove debugging console.logs and nodejs_compat flag
([#2553](#2553))
([6ceb299](6ceb299))
* Revert "fix: try older w3up client"
([#2549](#2549))
([b31847b](b31847b))
* revert debugging prs
([#2539](#2539))
([ba22d01](ba22d01))
* try older w3up client
([#2548](#2548))
([5d94ec5](5d94ec5))
* upgrade @ipld/dag-cbor
([#2534](#2534))
([964a12c](964a12c))


### Other Changes

* add a bunch of console.logs
([#2544](#2544))
([2fc34f3](2fc34f3))
* expose simple route to debug
([#2546](#2546))
([8a9aef5](8a9aef5))
* simple test case to check limits
([#2550](#2550))
([6a50a70](6a50a70))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants