This repository has been archived by the owner on Mar 2, 2022. It is now read-only.
feat: initial implementation #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/initial-implementation
branch
5 times, most recently
from
0e0e90d to
adff84b
Compare
vasco-santos
commented
Jan 13, 2022
| ) | ||
|
|
||
| const inspection = await inspectCarBlocks(rootCid, stat.blocksIterator) | ||
| structure = inspection.structure || metadata.structure |
There was a problem hiding this comment.
We can't simply trust in metadata.structure because it will not inspect the dag within the CAR. So mayb, we can drop it here after all
vasco-santos
force-pushed
the
feat/initial-implementation
branch
from
adff84b to
60a4376
Compare
vasco-santos
force-pushed
the
feat/initial-implementation
branch
from
60a4376 to
473e9c7
Compare
vasco-santos
force-pushed
the
feat/initial-implementation
branch
from
473e9c7 to
b2ca245
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the initial implementation of the read test lambda.
There are still a few challenges to figure out, regarding larger/incomplete CAR files. As a result this MVP version comes with a few assumptions (described in the README) on when to actually try a read test.
Closes nftstorage/nft.storage#755