Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: dont use ipjs and add package.json exports[].types #18

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Dec 12, 2023

Motivation:

  • I was getting errors due to no exports[].types in package.json
  • I couldn't get it all happy while also keeping ipjs e.g. because ipjs was trying to build ./dist and/or ./types and I couldn't find a way to ignore those. Hope its ok to drop ipjs.

Notes:

  • breaking change since it changes how the npm package is laid out and could cause hiccups for dependers

@gobengo gobengo changed the title feat: dont use ipjs and add package.json exports[].types fix: dont use ipjs and add package.json exports[].types Dec 12, 2023
@gobengo gobengo marked this pull request as ready for review December 12, 2023 21:20
@gobengo gobengo requested a review from alanshaw December 12, 2023 21:20
@gobengo gobengo self-assigned this Dec 12, 2023
@gobengo gobengo changed the title fix: dont use ipjs and add package.json exports[].types feat!: dont use ipjs and add package.json exports[].types Dec 12, 2023
@alanshaw alanshaw merged commit 1c0ca96 into main Dec 12, 2023
2 checks passed
@alanshaw alanshaw deleted the noipjs-and-fix-types branch December 12, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants