feat: initial implementation #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
feat/initial-implementation
branch
4 times, most recently
from
6d4ff22 to
264452c
Compare
vasco-santos
force-pushed
the
feat/initial-implementation
branch
from
264452c to
c368952
Compare
vasco-santos
force-pushed
the
feat/initial-implementation
branch
4 times, most recently
from
406a735 to
bb7b650
Compare
vasco-santos
force-pushed
the
feat/initial-implementation
branch
from
bb7b650 to
1b51a4e
Compare
vasco-santos
force-pushed
the
feat/initial-implementation
branch
from
f24c960 to
25fd570
Compare
vasco-santos
commented
Mar 15, 2022
|
|
||
| There are a few assumptions in place and this lambda function will assemble CARs if: | ||
| - S3 Object Metadata has a "Complete" structure | ||
| - S3 Object has a DagPB encoded root with a known size __acceptable__ (100MB) and the S3 directory for that root CID already has all the DAG chunks |
There was a problem hiding this comment.
todo: Need to tweak size yet
vasco-santos
force-pushed
the
feat/initial-implementation
branch
from
754bcd5 to
8d472fd
Compare
olizilla
reviewed
Mar 15, 2022
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| with: | ||
| node-version: '14' |
There was a problem hiding this comment.
Why test on node 14 when the deploy script uses 16?
There was a problem hiding this comment.
AWS does not support node16 https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
Deploy script is irrelevant, but I think we can change to 14
olizilla
reviewed
Mar 15, 2022
olizilla
reviewed
May 17, 2022
| const cbor = require('@ipld/dag-cbor') | ||
| const pb = require('@ipld/dag-pb') | ||
|
|
||
| const MAX_BLOCK_SIZE = 1 << 20 // Maximum permitted block size in bytes (1MiB). |
There was a problem hiding this comment.
Suggested change
| const MAX_BLOCK_SIZE = 1 << 20 // Maximum permitted block size in bytes (1MiB). | |
| const MAX_BLOCK_SIZE = 1 << 21 // Maximum permitted block size in bytes (2MiB). |
since https://github.com/web3-storage/web3.storage/pull/1269/files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
assemble-carslambda implementation.It is worth mentioning that it follows same patterns as used in IPFS Elastic Provider:
TODO:
Closes nftstorage/nftstorage.link#20