Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

95 release v100 requirements #147

Merged
merged 3 commits into from
Feb 4, 2025
Merged

95 release v100 requirements #147

merged 3 commits into from
Feb 4, 2025

Conversation

kubranarci
Copy link
Contributor

@kubranarci kubranarci commented Feb 3, 2025 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/variantbenchmarking branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@kubranarci kubranarci linked an issue Feb 3, 2025 that may be closed by this pull request
Release v1.0.0 requirements #95
Closed
@kubranarci kubranarci requested a review from maxulysse February 3, 2025 13:39
maxulysse
maxulysse reviewed Feb 3, 2025
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
maxulysse
maxulysse reviewed Feb 3, 2025
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
@heylf heylf self-assigned this Feb 4, 2025
@khersameesh24 khersameesh24 self-requested a review February 4, 2025 12:25
khersameesh24
khersameesh24 approved these changes Feb 4, 2025
View reviewed changes
Copy link

@khersameesh24 khersameesh24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kubranarci kubranarci merged commit d426f5d into dev Feb 4, 2025
16 checks passed
heylf
heylf approved these changes Feb 4, 2025
View reviewed changes
Copy link

@heylf heylf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse left review comments

@heylf heylf heylf approved these changes

@khersameesh24 khersameesh24 khersameesh24 approved these changes

Assignees

@heylf heylf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release v1.0.0 requirements
4 participants
@kubranarci @maxulysse @heylf @khersameesh24