Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format name/value with YAML syntax #3442

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

format name/value with YAML syntax #3442

wants to merge 3 commits into from
+3 −2

Conversation

matbonfanti
Copy link

@matbonfanti matbonfanti commented Feb 3, 2025 •
edited
Loading

This PR fixes the incorrect formatting of the params file generated by the nf-core pipelines create-params-file command (issue #3441). The output written with the name = value format has been corrected to name: value.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

mashehu
mashehu approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

nf_core/pipelines/params_file.py Show resolved Hide resolved
tests/pipelines/test_params_file.py Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.32%. Comparing base (639e419) to head (02dcbb7).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matbonfanti @mashehu @nf-core-bot